Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create formatter #970

Closed
amontanez24 opened this issue Aug 19, 2022 · 0 comments · Fixed by #1007
Closed

Create formatter #970

amontanez24 opened this issue Aug 19, 2022 · 0 comments · Fixed by #1007
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@amontanez24
Copy link
Contributor

amontanez24 commented Aug 19, 2022

Problem Description

As a user, it would be great if synthesized data matched the same numerical format (decimal places) as the fitted data.

The constraints have their reverse_transform after the HyperTransformer and sometimes ruin the formatting. As opposed to adding this formatting check in every constraint, we can pull out this logic into formatting classes that the DataProcessor can use.

Expected behavior

  • Create a NumericalFormatter class
  • Add a learn_format method that learns the required information from a column.
  • Add a format_data method that applies the learned format to a passed in column.

Additional context

@amontanez24 amontanez24 added feature request Request for a new feature new Automatic label applied to new issues labels Aug 19, 2022
@npatki npatki removed the new Automatic label applied to new issues label Aug 19, 2022
@amontanez24 amontanez24 added this to the 1.0.0 milestone Sep 2, 2022
This was referenced Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants