Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fit_columns_model parameter #834

Closed
amontanez24 opened this issue Jun 5, 2022 · 0 comments · Fixed by #841
Closed

Remove fit_columns_model parameter #834

amontanez24 opened this issue Jun 5, 2022 · 0 comments · Fixed by #841
Labels
feature request Request for a new feature
Milestone

Comments

@amontanez24
Copy link
Contributor

Problem Description

As a user, it is hard to understand what the fit_columns_model parameter does because it forces me to learn about the specific method of how conditional sampling for some constraints is handled.

Expected behavior

  • Remove the fit_columns_model parameter
  • Move any code related to the columns model into its own columns model class

Additional context

  • In constraints.base.py the _validate_constraint_columns method should be changed to just raise the MissingConstraintColumnsError if any columns are missing.
  • The _reject_sample and sample_constraint_columns methods can be moved into the columns_model class which can be renamed to something more appropriate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants