You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a user, it is sometimes unclear how to define a Between constraint since some parameters can take multiple values, and some parameters are required depending on the values for other parameters.
For example, low can be a column name or a scalar, but if it is a scalar than I must provide the high_is_scalar option. To simplify, we propose splitting this constraint into two different constraints: Range and ScalarRange. The first constrains a column between two other columns and the second constrains a column between two scalar values.
Expected behavior
Remove Between constraint
Add Range constraint
Init parameters should be:
low_column_name: String that is the column name for the lower bound
middle_column_name: String that is the column name for the column to be constrained
high_column_name: String that is the column name for the upper bound
strict_boundaries: Boolean for whether or not to make the range inclusive. Defaults to True
Add ScalarRange constraint:
Init parameters should be:
column_name: String that is the name of the column to constrain
low_value: Int or float that is the lower bound
high_value: Int or float that is the upper bound
strict_boundaries: Boolean for whether or not to make the range inclusive. Defaults to True
Logical changes
Currently the data sometimes doesn't round back to the appropriate number of decimals. For example, if the data passed in to reverse_transform is rounded to the nearest hundredth, then the returned data should be as well.
Additional context
The issue with rounding might require some investigation
The text was updated successfully, but these errors were encountered:
Problem Description
As a user, it is sometimes unclear how to define a
Between
constraint since some parameters can take multiple values, and some parameters are required depending on the values for other parameters.For example,
low
can be a column name or a scalar, but if it is a scalar than I must provide thehigh_is_scalar
option. To simplify, we propose splitting this constraint into two different constraints:Range
andScalarRange
. The first constrains a column between two other columns and the second constrains a column between two scalar values.Expected behavior
Between
constraintRange
constraintlow_column_name
: String that is the column name for the lower boundmiddle_column_name
: String that is the column name for the column to be constrainedhigh_column_name
: String that is the column name for the upper boundstrict_boundaries
: Boolean for whether or not to make the range inclusive. Defaults toTrue
ScalarRange
constraint:column_name
: String that is the name of the column to constrainlow_value
: Int or float that is the lower boundhigh_value
: Int or float that is the upper boundstrict_boundaries
: Boolean for whether or not to make the range inclusive. Defaults toTrue
reverse_transform
is rounded to the nearest hundredth, then the returned data should be as well.Additional context
The text was updated successfully, but these errors were encountered: