Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hybrid strategy to replace only invalid sampled rows in constraint #505

Closed
amontanez24 opened this issue Jul 9, 2021 · 3 comments
Closed

Add hybrid strategy to replace only invalid sampled rows in constraint #505

amontanez24 opened this issue Jul 9, 2021 · 3 comments
Labels
feature:constraints Related to inputting rules or business logic feature request Request for a new feature resolution:out of scope The SDV is not designed to solve this problem

Comments

@amontanez24
Copy link
Contributor

Problem Description

Add a change to the base Constraint class that would replace only the invalid rows that are sampled, with the reverse_transformed rows that the constraint creates.
@amontanez24 amontanez24 added feature request Request for a new feature pending review labels Jul 9, 2021
@npatki
Copy link
Contributor

npatki commented Jun 10, 2022

Seems our new handling strategy changes for constraints will cover this logic and more (#833).

I'll close this off as stale but please re-open if there are other items here to consider.

@npatki npatki closed this as not planned Won't fix, can't repro, duplicate, stale Jun 10, 2022
@amontanez24
Copy link
Contributor Author

This is not covered by the new handling_strategy and is kind of unrelated. It may no longer apply but we should take a closer look

@amontanez24 amontanez24 reopened this Jun 10, 2022
@npatki npatki added the feature:constraints Related to inputting rules or business logic label Jun 28, 2022
@amontanez24
Copy link
Contributor Author

This is marked as will not do

@npatki npatki added the resolution:out of scope The SDV is not designed to solve this problem label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature:constraints Related to inputting rules or business logic feature request Request for a new feature resolution:out of scope The SDV is not designed to solve this problem
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@npatki @amontanez24