Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GaussianCopula: rename distribution argument to field_distributions #237

Closed
csala opened this issue Nov 4, 2020 · 0 comments · Fixed by #251
Closed

GaussianCopula: rename distribution argument to field_distributions #237

csala opened this issue Nov 4, 2020 · 0 comments · Fixed by #251
Assignees
@csala
Labels
internal The issue doesn't change the API or functionality
Milestone
0.5.0

Comments

@csala
Copy link
Contributor

csala commented Nov 4, 2020

  • SDV version: 0.4.5

Description

The distributions argument from the GaussianCopula should be renamed to field_distributions to be consistent with the CopulaGAN implementation and facilitate comprehension.

The input type should also be either a dict or None, since the current behavior when a str is passed is actually shadowing the default_distribution argument.
@csala csala changed the title GaussianCopula: rename distributions argument to field_distributions GaussianCopula: rename distribution argument to field_distributions Nov 4, 2020
@csala csala self-assigned this Nov 4, 2020
@csala csala added the internal The issue doesn't change the API or functionality label Nov 4, 2020
@csala csala mentioned this issue Nov 19, 2020
Merged
@csala csala added this to the 0.4.6 milestone Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csala csala

Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Rename GaussianCopula distribution to field_distributions sdv-dev/SDV
1 participant
@csala