Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for 'Adding Constraints' demo #1280

Closed
amontanez24 opened this issue Feb 25, 2023 · 0 comments
Closed

Add integration tests for 'Adding Constraints' demo #1280

amontanez24 opened this issue Feb 25, 2023 · 0 comments
Assignees
Labels
internal The issue doesn't change the API or functionality
Milestone

Comments

@amontanez24
Copy link
Contributor

amontanez24 commented Feb 25, 2023

Problem Description

As part of migrating to SDV 1.0, we are creating new demos! Since running the old demos as a workflow caused problems (took a long time and sometimes failed due to jupyter dependencies), we want to make sure that all of the processes in the new demos are made into integration tests.

Expected behavior

  • Make integration tests for all of the SDV processes ran in the "Adding Constraints" demo.

Technical Details

  • Put the tests in the appropriate files. If you are adding tests that run methods for a SingleTableSynthesizer, put it in the file for that synthesizer ie. (tests/integration/single_table/copulas.py)
  • We don't need to be very strict on the asserts. Just add basic asserts to ensure things aren't broken. For example,
    • Assert sampled data is the right shape
    • Validate the sampled data
    • Make sure any key values in the output are present
  • Test loading from a different file. You can download the file with the custom constraint here
@amontanez24 amontanez24 added feature request Request for a new feature internal The issue doesn't change the API or functionality labels Feb 25, 2023
@amontanez24 amontanez24 added this to the 1.0.0 milestone Feb 25, 2023
@amontanez24 amontanez24 removed the feature request Request for a new feature label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Development

No branches or pull requests

2 participants