Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validate to PARSynthesizer #1081

Closed
amontanez24 opened this issue Oct 21, 2022 · 0 comments
Closed

Add validate to PARSynthesizer #1081

amontanez24 opened this issue Oct 21, 2022 · 0 comments
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@amontanez24
Copy link
Contributor

Problem Description

As a user, it would be helpful if there was a way to see if my sequential data is correct according to my metadata.

Acceptance criteria

  • Add a method called validate to the PARSynthesizer
  • This method should make the same checks as the BaseSynthesizer.validate plus the following one
    • Context columns (stored in the model's parameters) should be fixed for each sequence – ie if you group by sequence key, the context columns should not vary
      Error: Context column 'patient_address' is changing inside sequence ('Patient_ID'='ID_004').

Expected behavior

synthesizer.validate(data)
InvalidDataError: The provided data does not match the metadata

Error: Context column 'patient_address' is changing inside sequence ('Patient_ID'='ID_004').

Additional context

  • The PARSynthesizer does not inherit from the BaseSynthesizer class. This is mostly because the sampling methods for these classes are different. It might be worth investigating ways to refactor the code so that there isn't too much repetition. One option could be mixins. We could have a mixin for most of the repeated functionality that both PARSynthesizer and BaseSynthesizer inherit from.
@amontanez24 amontanez24 added the feature request Request for a new feature label Oct 21, 2022
@amontanez24 amontanez24 added this to the 1.0.0 milestone Oct 21, 2022
@amontanez24 amontanez24 self-assigned this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

1 participant