Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an error if an invalid sdtype is provided to the metadata #1042

Closed
amontanez24 opened this issue Sep 28, 2022 · 0 comments
Closed

Raise an error if an invalid sdtype is provided to the metadata #1042

amontanez24 opened this issue Sep 28, 2022 · 0 comments
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@amontanez24
Copy link
Contributor

amontanez24 commented Sep 28, 2022

Problem Description

As a user, it's confusing when I see an error message that says I passed the wrong arguments when the actual problem was a typo in the sdtype.

Expected behavior

When adding a colum,n or validating the metadata, do the following steps:

  1. Check to see if sdtype is:
    (a) commonly supported 'numerical', 'datetime', etc.
    (b) included in our mapping 'physical_address', 'ipv4_address', etc.
    (c) found as a Faker function
  2. Throw the following error if it is none of the above:
    Invalid sdtype : '{provided_sdtype}' is not recognized. Please use one of the supported SDV sdtypes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

1 participant