Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMDB recommendations have duplicates #3499

Open
1 task done
marcofaggian opened this issue Jun 12, 2023 · 3 comments
Open
1 task done

TMDB recommendations have duplicates #3499

marcofaggian opened this issue Jun 12, 2023 · 3 comments

Comments

@marcofaggian
Copy link
Contributor

Description

The last element of the first movie recommendations' page is the same of the next pagination. Root cause is the TMDB API's response.

There are two ways to solve this:

  1. return a page of 19 from the backend (there's no way to check with previous page, without caching or network calls),
  2. (if found to be the same) skip the first element of the next page whilst stitching together the pages in the frontend.

Both have pros and cons, I'd implement a PR for the second one.

Version

1.4.1

Steps to Reproduce

Fetch the recommendations API for a TMDB movie, look at the last recommendation of the first page. It's identical to the first recommendation of the second page.

Screenshots

immagine

Logs

No response

Platform

desktop

Device

any

Operating System

any

Browser

any

Additional Context

Coming from downstream jellyseerr issue

Code of Conduct

  • I agree to follow Overseerr's Code of Conduct
@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@Panda260
Copy link

Panda260 commented Apr 3, 2024

i have the same issue

@stale stale bot removed the stale label Apr 3, 2024
Copy link

stale bot commented Feb 1, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants