Skip to content
This repository has been archived by the owner on Sep 6, 2024. It is now read-only.

Commit

Permalink
feat(1555): Pass in UI URI to launcher (#56)
Browse files Browse the repository at this point in the history
  • Loading branch information
tkyi authored Mar 28, 2019
1 parent 0a8b67c commit c54093d
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 5,311 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ npm-debug.log
.DS_STORE
.*.swp
.nyc_output/*
package-lock.json
33 changes: 2 additions & 31 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,32 +1,3 @@
# Contributing
# Contributing to Screwdriver

Thank you for considering contributing! There are many ways you can help.

## Issues

File an issue if you think you've found a bug. Be sure to describe

1. How can it be reproduced?
2. What did you expect?
3. What actually occurred?
4. Version, platform, etc. if possibly relevant.

## Docs

Documentation, READMEs, and examples are extremely important. Please help improve them and if you find a typo or notice a problem, please send a fix or say something.

## Submitting Patches

Patches for fixes, features, and improvements are accepted through pull requests.

* Write good commit messages, in the present tense! (Add X, not Added X). Short title, blank line, bullet points if needed. Capitalize the first letter of the title or bullet item. No punctuation in the title.
* Code must pass lint and style checks.
* All external methods must be documented.
* Include tests to improve coverage and prevent regressions.
* Squash changes into a single commit per feature/fix. Ask if you're unsure how to discretize your work.

Please ask before embarking on a large improvement so you're not disappointed if it does not align with the goals of the project or owner(s).

## Feature Requests

Make the case for a feature via an issue with a good title. The feature should be discussed and given a target inclusion milestone or closed.
Have a look at our guidelines, as well as pointers on where to start making changes, in our official [documentation](https://docs.screwdriver.cd/about/contributing).
1 change: 1 addition & 0 deletions config/pod.yaml.tim
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ spec:
"--container", "{{container}}",
"--api_uri", "{{api_uri}}",
"--store_uri", "{{store_uri}}",
"--ui_uri", "{{ui_uri}}",
"--build_id", "{{build_id}}",
"--id_with_prefix", "{{build_id_with_prefix}}",
"--build_token", "{{token}}",
Expand Down
2 changes: 2 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ class K8sVMExecutor extends Executor {
* @param {Object} options.ecosystem.api Routable URI to Screwdriver API
* @param {Object} [options.ecosystem.pushgatewayUrl] Pushgateway URL for Prometheus
* @param {Object} options.ecosystem.store Routable URI to Screwdriver Store
* @param {Object} options.ecosystem.ui Routable URI to Screwdriver UI
* @param {Object} options.kubernetes Kubernetes configuration
* @param {String} [options.kubernetes.token] API Token (loaded from /var/run/secrets/kubernetes.io/serviceaccount/token if not provided)
* @param {String} [options.kubernetes.host=kubernetes.default] Kubernetes hostname
Expand Down Expand Up @@ -286,6 +287,7 @@ class K8sVMExecutor extends Executor {
container,
api_uri: this.ecosystem.api,
store_uri: this.ecosystem.store,
ui_uri: this.ecosystem.ui,
pushgateway_url: hoek.reach(this.ecosystem, 'pushgatewayUrl', { default: '' }),
token,
launcher_image: `${this.launchImage}:${this.launchVersion}`,
Expand Down
Loading

0 comments on commit c54093d

Please sign in to comment.