Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run cpp tests in CI #2164

Closed
ianna opened this issue Jan 26, 2023 · 1 comment · Fixed by #2169
Closed

run cpp tests in CI #2164

ianna opened this issue Jan 26, 2023 · 1 comment · Fixed by #2169
Labels
feature New feature or request

Comments

@ianna
Copy link
Collaborator

ianna commented Jan 26, 2023

Version of Awkward Array

2.0.6

Description and code to reproduce

@agoose77 and @jpivarski - I think, we need to have at least one node to run the cpp tests.

@ianna ianna added the bug (unverified) The problem described would be a bug, but needs to be triaged label Jan 26, 2023
@agoose77
Copy link
Collaborator

Agreed! IIRC the C++ tests are only testing the shared libraries, right? Perhaps they should be moved back into the root Git directory, and then built as a dedicated target. We can discuss today :)

@agoose77 agoose77 added feature New feature or request and removed bug (unverified) The problem described would be a bug, but needs to be triaged labels Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants