pre-commit hook does not work on Windows

[radoering]

When I try to use the pre-commit hook on Windows it always fails with

UnicodeEncodeError: 'charmap' codec can't encode character '\u2705' in position
1: character maps to <undefined>

or

UnicodeEncodeError: 'charmap' codec can't encode character '\u274c' in position
1: character maps to <undefined>

The unicode characters mentioned in the error are ✅ and ❌.

I tried it in cmd, Powershell and Git Bash and always got these errors.

I can reproduce this issue by just creating an empty git repo with just a .pre-commit-config.yaml with:

repos:
  - repo: https://github.com/scientific-python/cookie
    rev: 2024.04.23
    hooks:
      - id: sp-repo-review

and running pre-commit run --all-files.

[henryiii]

As a quick fix, you can set PYTHONUTF8=1 and I think that will fix it (Python 3.15 would fix it too, but that's a couple of years away). Something is missing the encoding specifier, hopefully in repo-review or sp-repo-review. Will check.

[henryiii]

This has been fixed in https://github.com/scientific-python/repo-review/releases/tag/v0.11.1 - though pre-commit caches globally, so there will be a new release here soon which should ensure that gets picked up.

[henryiii]

Fixed in latest releases!