Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for a powershell install script for a dev env #4317

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.96%. Comparing base (5bf53e0) to head (00411e1).
Report is 366 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4317      +/-   ##
==========================================
- Coverage   75.45%   70.96%   -4.50%     
==========================================
  Files         202      292      +90     
  Lines       44323    65261   +20938     
==========================================
+ Hits        33444    46312   +12868     
- Misses       9653    17326    +7673     
- Partials     1226     1623     +397     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@karibou karibou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to use some kind of placeholder rather than an actual real ssh-key

}

# Replace this line with your own SSH key
echo "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIM6Lfs9IrfEUsw2oALOKucAqjeJo3vdADJAZS0BrJ4Vl rleone@scaleway.com" > "C:\ProgramData\ssh\administrators_authorized_keys"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to use some kind of placeholder rather than an actual real ssh-key

Copy link

@karibou karibou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@remyleone remyleone added this pull request to the merge queue Dec 3, 2024
Merged via the queue into scaleway:master with commit 54b7fe9 Dec 3, 2024
13 checks passed
@remyleone remyleone deleted the windows_script branch December 3, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants