-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for a powershell install script for a dev env #4317
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4317 +/- ##
==========================================
- Coverage 75.45% 70.96% -4.50%
==========================================
Files 202 292 +90
Lines 44323 65261 +20938
==========================================
+ Hits 33444 46312 +12868
- Misses 9653 17326 +7673
- Partials 1226 1623 +397 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be better to use some kind of placeholder rather than an actual real ssh-key
scripts/windows/install.ps1
Outdated
} | ||
|
||
# Replace this line with your own SSH key | ||
echo "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIM6Lfs9IrfEUsw2oALOKucAqjeJo3vdADJAZS0BrJ4Vl rleone@scaleway.com" > "C:\ProgramData\ssh\administrators_authorized_keys" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be better to use some kind of placeholder rather than an actual real ssh-key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Community Note
Relates OR Closes #0000
Release note for CHANGELOG: