Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(instance): get server type when loading commercialType #3963

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jul 8, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@Codelax Codelax added the instance Instance issues, bugs and feature requests label Jul 8, 2024
@Codelax Codelax self-assigned this Jul 8, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.32%. Comparing base (5bf53e0) to head (6e2ce22).
Report is 147 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (6e2ce22). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (6e2ce22)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3963      +/-   ##
==========================================
- Coverage   75.45%   69.32%   -6.14%     
==========================================
  Files         202      291      +89     
  Lines       44323    55168   +10845     
==========================================
+ Hits        33444    38244    +4800     
- Misses       9653    15359    +5706     
- Partials     1226     1565     +339     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Jul 8, 2024
Merged via the queue into scaleway:master with commit 1bc46f4 Jul 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants