fix(autocomplete): add basename arg for custom path #3829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0b72ae to
ee47af4
Compare
Codelax
previously approved these changes
May 23, 2024
Codelax
reviewed
May 23, 2024
| func autocompleteScripts(ctx context.Context) map[string]autocompleteScript { | ||
| binaryName := core.ExtractBinaryName(ctx) | ||
| func autocompleteScripts(ctx context.Context, basename string) map[string]autocompleteScript { | ||
| binaryName := basename |
There was a problem hiding this comment.
why not use binaryName as function argument ?
There was a problem hiding this comment.
good question, because the arg is call basename but I can change it to binaryName
decbebf to
d3885dd
Compare
d3885dd to
53d15c3
Compare
Codelax
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3676
close #1959