Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redis): add autocompletion for setting name #3707

Conversation

jremy42
Copy link
Contributor

@jremy42 jremy42 commented Mar 7, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


close #2958

@jremy42 jremy42 force-pushed the feat/add-autocompletion-for-setting-redis-cluster branch from c38f55b to 4b841f1 Compare March 8, 2024 09:23
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 12.12121% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 75.80%. Comparing base (f7fa405) to head (4b841f1).

Files Patch % Lines
internal/namespaces/redis/v1/custom_cluster.go 9.37% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3707      +/-   ##
==========================================
- Coverage   75.85%   75.80%   -0.05%     
==========================================
  Files         194      194              
  Lines       43193    43226      +33     
==========================================
+ Hits        32765    32769       +4     
- Misses       9226     9255      +29     
  Partials     1202     1202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vinzius Vinzius changed the title feat(redis) : add autocompletion for setting name feat(redis): add autocompletion for setting name Mar 12, 2024
@remyleone remyleone added this pull request to the merge queue Mar 13, 2024
Merged via the queue into scaleway:master with commit 45e774f Mar 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add autocompletion on settings for redis
3 participants