Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vpc): filter private_networks by ids and add support for nl-ams-2 and pl-waw-2 #2685

Merged
merged 3 commits into from
Dec 27, 2022

Conversation

scaleway-bot
Copy link
Contributor

No description provided.

@remyleone remyleone changed the title feat(vpc): filter private_networks by ids feat(vpc): filter private_networks by ids and add support for nl-ams-2 and pl-waw-2 Dec 27, 2022
@remyleone remyleone self-assigned this Dec 27, 2022
@remyleone remyleone added the vpc Virtual Private Cloud (VPC) issues, bugs and feature requests label Dec 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2022

Codecov Report

Merging #2685 (412140d) into master (15fa7a9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2685   +/-   ##
=======================================
  Coverage   75.98%   75.99%           
=======================================
  Files         134      134           
  Lines       24767    24774    +7     
=======================================
+ Hits        18820    18827    +7     
  Misses       5317     5317           
  Partials      630      630           
Impacted Files Coverage Δ
internal/namespaces/vpc/v1/vpc_cli.go 91.42% <100.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@remyleone remyleone merged commit 6b45df6 into scaleway:master Dec 27, 2022
@remyleone remyleone deleted the v1.3034.0 branch December 27, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants