Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lb): add servers to backend via tags #2683

Merged
merged 4 commits into from
Dec 27, 2022

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Dec 19, 2022

No description provided.

@yfodil yfodil added enhancement load-balancer Load-balancer issues, bugs and feature requests instance Instance issues, bugs and feature requests elastic-metal Elastic-metal issues, bugs and feature requests labels Dec 19, 2022
@yfodil yfodil self-assigned this Dec 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2022

Codecov Report

Merging #2683 (9954591) into master (bb49d6c) will decrease coverage by 0.41%.
The diff coverage is 31.74%.

@@            Coverage Diff             @@
##           master    #2683      +/-   ##
==========================================
- Coverage   75.97%   75.56%   -0.42%     
==========================================
  Files         134      134              
  Lines       24790    25026     +236     
==========================================
+ Hits        18835    18911      +76     
- Misses       5325     5475     +150     
- Partials      630      640      +10     
Impacted Files Coverage Δ
internal/namespaces/lb/v1/custom_backend.go 44.64% <31.74%> (-6.88%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

remyleone
remyleone previously approved these changes Dec 27, 2022
@remyleone remyleone merged commit fa9a24b into scaleway:master Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elastic-metal Elastic-metal issues, bugs and feature requests enhancement instance Instance issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation about adding instances automatically from a tag in a load balancer backend
3 participants