Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lb): add servers to backend via id #2679

Merged
merged 2 commits into from
Dec 16, 2022
Merged

feat(lb): add servers to backend via id #2679

merged 2 commits into from
Dec 16, 2022

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Dec 15, 2022

No description provided.

@yfodil yfodil added enhancement load-balancer Load-balancer issues, bugs and feature requests instance Instance issues, bugs and feature requests elastic-metal Elastic-metal issues, bugs and feature requests labels Dec 15, 2022
@yfodil yfodil self-assigned this Dec 15, 2022
@yfodil yfodil linked an issue Dec 15, 2022 that may be closed by this pull request
Have a command to quickly add an instance to a load balancer #1256
Closed
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022 •
edited
Loading

Codecov Report

Merging #2679 (430fc58) into master (ce50296) will decrease coverage by 0.42%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #2679      +/-   ##
==========================================
- Coverage   76.45%   76.02%   -0.43%     
==========================================
  Files         134      134              
  Lines       24409    24749     +340     
==========================================
+ Hits        18662    18816     +154     
- Misses       5129     5303     +174     
- Partials      618      630      +12
Impacted Files Coverage Δ
internal/namespaces/lb/v1/custom_backend.go 51.52% <50.00%> (-5.95%) ⬇️
internal/namespaces/lb/v1/lb_cli.go 86.65% <0.00%> (-0.78%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@remyleone remyleone merged commit 7a35753 into scaleway:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

Assignees

@yfodil yfodil

Labels
elastic-metal Elastic-metal issues, bugs and feature requests enhancement instance Instance issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have a command to quickly add an instance to a load balancer
3 participants
@yfodil @codecov-commenter @remyleone