Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rdb): improve ACL deletion message #2669

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Dec 6, 2022

No description provided.

@yfodil yfodil added enhancement rdb Managed MySQL and PostgreSQL issues, bugs and feature requests labels Dec 6, 2022
@yfodil yfodil self-assigned this Dec 6, 2022
@yfodil yfodil marked this pull request as ready for review December 6, 2022 08:42
@yfodil yfodil linked an issue Dec 6, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #2669 (dd53b77) into master (77ff45b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2669   +/-   ##
=======================================
  Coverage   76.80%   76.80%           
=======================================
  Files         133      133           
  Lines       24152    24156    +4     
=======================================
+ Hits        18550    18554    +4     
  Misses       4998     4998           
  Partials      604      604           
Impacted Files Coverage Δ
internal/namespaces/rdb/v1/custom_acl.go 86.20% <100.00%> (+0.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yfodil yfodil merged commit 85c1bfb into scaleway:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement rdb Managed MySQL and PostgreSQL issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve successful deletion message on rdb acl delete
3 participants