Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iot): improve network create output #2584

Merged
merged 4 commits into from
Nov 16, 2022

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Nov 14, 2022

feat #1437

@yfodil yfodil self-assigned this Nov 14, 2022
@yfodil yfodil added enhancement iot IoT issues, bugs and feature requests labels Nov 14, 2022
@yfodil yfodil marked this pull request as ready for review November 14, 2022 13:46
@yfodil yfodil linked an issue Nov 14, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #2584 (61bdce1) into master (ebbf6a8) will increase coverage by 0.48%.
The diff coverage is 83.78%.

@@            Coverage Diff             @@
##           master    #2584      +/-   ##
==========================================
+ Coverage   76.01%   76.49%   +0.48%     
==========================================
  Files         126      130       +4     
  Lines       22282    23758    +1476     
==========================================
+ Hits        16937    18173    +1236     
- Misses       4779     4990     +211     
- Partials      566      595      +29     
Impacted Files Coverage Δ
internal/namespaces/iot/v1/custom_network.go 73.91% <73.91%> (ø)
internal/namespaces/iot/v1/custom.go 100.00% <100.00%> (ø)
internal/namespaces/iot/v1/custom_hub.go 100.00% <100.00%> (ø)
internal/namespaces/iot/v1/iot_cli.go 83.64% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yfodil yfodil merged commit d19e6ad into scaleway:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement iot IoT issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix rendering of iot network create
4 participants