Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rdb): add instance update settings #2549

Merged
merged 5 commits into from
Oct 17, 2022
Merged

feat(rdb): add instance update settings #2549

merged 5 commits into from
Oct 17, 2022

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Oct 14, 2022 •
edited
Loading

feat #2198

@yfodil yfodil marked this pull request as ready for review October 17, 2022 07:51
@yfodil yfodil linked an issue Oct 17, 2022 that may be closed by this pull request
Add support for updating settings of an rdb instance #2198
Closed
@codecov-commenter
Copy link

Codecov Report

Merging #2549 (4635a1f) into master (87c712f) will increase coverage by 0.08%.
The diff coverage is 86.95%.

@@            Coverage Diff             @@
##           master    #2549      +/-   ##
==========================================
+ Coverage   75.88%   75.96%   +0.08%     
==========================================
  Files         126      126              
  Lines       21920    22081     +161     
==========================================
+ Hits        16634    16774     +140     
- Misses       4727     4743      +16     
- Partials      559      564       +5
Impacted Files Coverage Δ
internal/namespaces/rdb/v1/custom_instance.go 82.03% <86.87%> (+3.07%) ⬆️
internal/namespaces/rdb/v1/custom.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@remyleone remyleone added the rdb Managed MySQL and PostgreSQL issues, bugs and feature requests label Oct 17, 2022
@remyleone remyleone merged commit d963e7c into scaleway:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantumsheep quantumsheep quantumsheep left review comments

@remyleone remyleone remyleone approved these changes

Assignees

@yfodil yfodil

Labels
rdb Managed MySQL and PostgreSQL issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for updating settings of an rdb instance
4 participants
@yfodil @codecov-commenter @remyleone @quantumsheep