Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(instance): add image update command #2539

Merged
merged 5 commits into from
Oct 7, 2022
Merged

feat(instance): add image update command #2539

merged 5 commits into from
Oct 7, 2022

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Oct 6, 2022 •
edited
Loading

feat #2217

remyleone
remyleone reviewed Oct 6, 2022
View reviewed changes
internal/namespaces/instance/v1/custom_image.go
@@ -314,6 +315,125 @@ func imageDeleteBuilder(c *core.Command) *core.Command {
return c
}

//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it not generated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the UpdateImage method has been hand coded in the SDK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we check with the instance team if the update image could be generated now? Maybe the reasons of why it was hardcoded are no long true and it could be generated just like any other function

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kindermoumoute

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022 •
edited
Loading

Codecov Report

Merging #2539 (4a02d59) into master (d034a57) will increase coverage by 0.05%.
The diff coverage is 87.36%.

@@            Coverage Diff             @@
##           master    #2539      +/-   ##
==========================================
+ Coverage   75.82%   75.88%   +0.05%     
==========================================
  Files         126      126              
  Lines       21829    21920      +91     
==========================================
+ Hits        16552    16634      +82     
- Misses       4719     4727       +8     
- Partials      558      559       +1
Impacted Files Coverage Δ
...al/namespaces/baremetal/v1/custom_server_create.go 89.88% <ø> (-0.44%) ⬇️
internal/namespaces/instance/v1/custom_image.go 82.17% <87.23%> (+3.27%) ⬆️
internal/namespaces/instance/v1/custom.go 98.05% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yfodil yfodil linked an issue Oct 7, 2022 that may be closed by this pull request
missing scw instance image update #2217
Closed
@yfodil yfodil removed a link to an issue Oct 7, 2022
missing scw instance image update #2217
Closed
@yfodil yfodil marked this pull request as ready for review October 7, 2022 11:24
@yfodil yfodil linked an issue Oct 7, 2022 that may be closed by this pull request
missing scw instance image update #2217
Closed
@remyleone remyleone merged commit 38c93d3 into scaleway:master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing scw instance image update
3 participants
@yfodil @codecov-commenter @remyleone