Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance): remove unwanted required field on CreateSnapshot #2493

Merged
merged 2 commits into from
Sep 12, 2022
Merged

feat(instance): remove unwanted required field on CreateSnapshot #2493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12be2fa
feat: update generated cli
scaleway-bot Sep 7, 2022
755dfd7
Merge branch 'master' into v1.2705.0
remyleone Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/scw/testdata/test-all-usage-instance-snapshot-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ EXAMPLES:

ARGS:
[name=<generated>] Name of the snapshot
volume-id UUID of the volume
[volume-id] UUID of the volume
[unified] Whether a snapshot is unified or not.
[tags.{index}] The tags of the snapshot
[project-id] Project ID to use. If none is passed the default project ID will be used
Expand Down
2 changes: 1 addition & 1 deletion docs/commands/instance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1928,7 +1928,7 @@ scw instance snapshot create [arg=value ...]
| Name | | Description |
|------|---|-------------|
| name | Default: `<generated>` | Name of the snapshot |
| volume-id | Required | UUID of the volume |
| volume-id | | UUID of the volume |
| unified | | Whether a snapshot is unified or not. |
| tags.{index} | | The tags of the snapshot |
| project-id | | Project ID to use. If none is passed the default project ID will be used |
Expand Down
2 changes: 1 addition & 1 deletion internal/namespaces/instance/v1/instance_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1269,7 +1269,7 @@ func instanceSnapshotCreate() *core.Command {
{
Name: "volume-id",
Short: `UUID of the volume`,
Required: true,
Required: false,
Deprecated: false,
Positional: false,
},
Expand Down