Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shell mode #2433

Merged
merged 4 commits into from
Sep 14, 2022
Merged

feat: add shell mode #2433

merged 4 commits into from
Sep 14, 2022

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Aug 2, 2022

TODO:

  • A correct shell command
  • Ctrl-C doesn't work after quitting shell
  • use [namespace] command
  • in suggestions, put required options first
  • Allow switching profile and display used profile
  • Fix crash with invalid command
  • Refactor

@Codelax Codelax linked an issue Aug 2, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #2433 (c0a6186) into master (9681ee8) will decrease coverage by 0.58%.
The diff coverage is 11.88%.

@@            Coverage Diff             @@
##           master    #2433      +/-   ##
==========================================
- Coverage   76.45%   75.87%   -0.59%     
==========================================
  Files         125      126       +1     
  Lines       21570    21762     +192     
==========================================
+ Hits        16492    16511      +19     
- Misses       4521     4693     +172     
- Partials      557      558       +1     
Impacted Files Coverage Δ
internal/core/command.go 57.39% <0.00%> (-2.61%) ⬇️
internal/core/shell.go 10.49% <10.49%> (ø)
internal/core/bootstrap.go 72.46% <20.00%> (-2.36%) ⬇️
...nal/namespaces/instance/v1/custom_server_create.go 81.94% <36.36%> (-0.35%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Codelax Codelax marked this pull request as ready for review September 13, 2022 14:28
@Codelax Codelax merged commit 439341d into scaleway:master Sep 14, 2022
@Codelax Codelax deleted the shell branch September 15, 2022 07:58
@Codelax Codelax self-assigned this Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a shell option
3 participants