-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(instance): add support for unified in the backup command #2349
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2349 +/- ##
==========================================
- Coverage 76.28% 76.27% -0.02%
==========================================
Files 125 125
Lines 21053 21088 +35
==========================================
+ Hits 16060 16084 +24
- Misses 4454 4461 +7
- Partials 539 543 +4
Continue to review full report at Codecov.
|
Please add the unified parameter for the "scw instance snapshot create" command |
cmd/scw/testdata/test-all-usage-instance-server-backup-usage.golden
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the tests cover it, and all tests are ok it LGTM
If also need tests from internal users
Community Note
Relates OR Closes #0000
Release note for CHANGELOG: