Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance): add support for unified in the backup command #2349

Merged
merged 9 commits into from
Jun 16, 2022

Conversation

remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2022

Codecov Report

Merging #2349 (5b82458) into master (664e01f) will decrease coverage by 0.01%.
The diff coverage is 70.27%.

@@            Coverage Diff             @@
##           master    #2349      +/-   ##
==========================================
- Coverage   76.28%   76.27%   -0.02%     
==========================================
  Files         125      125              
  Lines       21053    21088      +35     
==========================================
+ Hits        16060    16084      +24     
- Misses       4454     4461       +7     
- Partials      539      543       +4     
Impacted Files Coverage Δ
internal/namespaces/instance/v1/custom_server.go 79.80% <66.66%> (-0.40%) ⬇️
internal/namespaces/instance/v1/custom_snapshot.go 70.11% <76.92%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 664e01f...5b82458. Read the comment docs.

@clement-gilbert
Copy link
Contributor

Please add the unified parameter for the "scw instance snapshot create" command

Copy link
Contributor

@clement-gilbert clement-gilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests cover it, and all tests are ok it LGTM
If also need tests from internal users

@remyleone remyleone merged commit 1f6dcdc into scaleway:master Jun 16, 2022
@remyleone remyleone deleted the unified_backup branch June 16, 2022 09:45
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants