feat(validation): add optional enum values with warning

internal/core/arg_specs.go

@@ -84,6 +84,10 @@ type ArgSpec struct {
 	// EnumValues contains all possible values of an enum.
 	EnumValues []string
 
+	// BadEnumWarning is the warning printed when the value is not in the EnumValues
+	// If not set, the value has to be in EnumeValues
+	BadEnumWarning string
+
 	// AutoCompleteFunc is used to autocomplete possible values for a given argument.
 	AutoCompleteFunc AutoCompleteArgFunc
 

internal/core/validate.go

@@ -142,6 +142,10 @@ func DefaultArgSpecValidateFunc() ArgSpecValidateFunc {
 		}
 
 		if !stringExists(argSpec.EnumValues, strValue) {
+			if argSpec.BadEnumWarning != "" {
+				logger.Warningf(argSpec.BadEnumWarning, strValue)
+				return nil
+			}
 			return InvalidValueForEnumError(argSpec.Name, argSpec.EnumValues, strValue)
 		}
 		return nil

internal/namespaces/instance/v1/custom_server_create.go

@@ -56,10 +56,11 @@ func serverCreateCommand() *core.Command {
 				AutoCompleteFunc: instanceServerCreateImageAutoCompleteFunc,
 			},
 			{
-				Name:       "type",
-				Short:      "Server commercial type",
-				Default:    core.DefaultValueSetter("DEV1-S"),
-				EnumValues: []string{"GP1-XS", "GP1-S", "GP1-M", "GP1-L", "GP1-XL", "DEV1-S", "DEV1-M", "DEV1-L", "DEV1-XL", "RENDER-S"},
+				Name:           "type",
+				Short:          "Server commercial type",
+				Default:        core.DefaultValueSetter("DEV1-S"),
+				EnumValues:     []string{"GP1-XS", "GP1-S", "GP1-M", "GP1-L", "GP1-XL", "DEV1-S", "DEV1-M", "DEV1-L", "DEV1-XL", "RENDER-S"},
+				BadEnumWarning: "The Commercial Type %s is not supported, it may misbehave\n",
 			},
 			{
 				Name:    "name",

internal/namespaces/instance/v1/testdata/test-create-server-errors-error-invalid-instance-type.golden

@@ -1,12 +1,7 @@
 🎲🎲🎲 EXIT CODE: 1 🎲🎲🎲
 🟥🟥🟥 STDERR️️ 🟥🟥🟥️
-Invalid value 'MACBOOK1-S' for arg 'type'
-
-Hint:
-Accepted values for 'type' are [GP1-XS GP1-S GP1-M GP1-L GP1-XL DEV1-S DEV1-M DEV1-L DEV1-XL RENDER-S]
+Bad image label 'ubuntu_bionic' for MACBOOK1-S
 🟥🟥🟥 JSON STDERR 🟥🟥🟥
 {
-  "message": "invalid value 'MACBOOK1-S' for arg 'type'",
-  "error": {},
-  "hint": "Accepted values for 'type' are [GP1-XS GP1-S GP1-M GP1-L GP1-XL DEV1-S DEV1-M DEV1-L DEV1-XL RENDER-S]"
+  "error": "bad image label 'ubuntu_bionic' for MACBOOK1-S"
 }