Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automatic code-quality tool in PR #917

Closed
remyleone opened this issue Apr 24, 2020 · 0 comments · Fixed by #1097
Closed

Add automatic code-quality tool in PR #917

remyleone opened this issue Apr 24, 2020 · 0 comments · Fixed by #1097
Milestone
v2.0.0

Comments

@remyleone
Copy link
Member

remyleone commented Apr 24, 2020 •
edited by jerome-quere
Loading

Golang ci is closing: https://medium.com/golangci/golangci-com-is-closing-d1fc1bd30e0e

We should create Github Action that executes a golangci-lint.

It is an open-source project that will still be maintained: https://github.com/golangci/golangci-lint.

We need to do it in the SDK Go and the CLI.

Running it as a simple GitHub action will not add a useful message in PR.

Maybe we could test a solution like https://github.com/reviewdog/reviewdog that support golangci

We should run:

  • golangci-lint like
  • goimports
@jerome-quere jerome-quere changed the title Create a golangci-lint Github action Create a golangci-lint Github actions Apr 24, 2020
@jerome-quere jerome-quere changed the title Create a golangci-lint Github actions Create a golangci-lint Github action Apr 24, 2020
@remyleone remyleone added this to the v2.0.0 milestone Apr 27, 2020
@remyleone remyleone mentioned this issue Apr 29, 2020
Closed
@jerome-quere jerome-quere changed the title Create a golangci-lint Github action Add automatic code-quality tool in PR Jun 4, 2020
@jerome-quere jerome-quere mentioned this issue Jun 4, 2020
Closed
@remyleone remyleone linked a pull request Jun 11, 2020 that will close this issue
ci: add github actions for using golangci #1097
Merged
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this issue Mar 3, 2022
@Monitob @remyleone
feat(lb): add support for private network in lb resource (scaleway#917)
81cf050 
* feat(lb-pn): add private network to lb

* feat(lb-pn): remote lb private network

* feat(lb-pn): add static_config test

* feat(lb-pn): update all lb cassettes

* feat(lb-pn): update all lb cassettes

* feat(lb-pn): set zone schema

* Update scaleway/resource_lb.go

Co-authored-by: Rémy Léone <remy.leone@gmail.com>

* feat(lb-pn): add wait private network state, update for private networks, test update

* feat(lb-pn): add wait private network state, update for private networks, test update

* feat(lb): update selector

* feat(lb-pn): remove trailing number

* feat(lb-pn): simplify static config check helper

Co-authored-by: Rémy Léone <remy.leone@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

ci: add github actions for using golangci remyleone/scaleway-cli
1 participant
@remyleone