Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation issue #2124

Closed
remyleone opened this issue Feb 15, 2022 · 1 comment
Closed

Documentation issue #2124

remyleone opened this issue Feb 15, 2022 · 1 comment
Assignees
Labels
bug k8s Kubernetes Kapsule issues, bugs and feature requests

Comments

@remyleone
Copy link
Member

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Here's a fix that can be done I guess, for the CLI's documentation about kubelet's additional settings : https://github.com/scaleway/scaleway-cli/blob/master/docs/commands/k8s.md#update-a-pool-in-a-cluster
In the table it should be : kubelet-args.{key} instead of kubelet-args.value.{key}
Issue spotted here : https://scaleway-community.slack.com/archives/CD9JPK4KF/p1644845477576589

Command attempted

scw k8s pool update <pool-id> kubelet-args.value.containerLogMaxSize=20Mi
Cannot unmarshal arg 'kubelet-args.value.containerLogMaxSize=20Mi': cannot set nested field for unmarshalable type string

Expected Behavior

Actual Behavior

More info

@remyleone remyleone added the bug label Feb 15, 2022
@remyleone remyleone added the k8s Kubernetes Kapsule issues, bugs and feature requests label Apr 21, 2022
@Codelax
Copy link
Member

Codelax commented Sep 20, 2022

Fixed in #2518

@Codelax Codelax closed this as completed Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug k8s Kubernetes Kapsule issues, bugs and feature requests
Projects
None yet
Development

No branches or pull requests

2 participants