Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 5ddcabb

Browse files
committedSep 16, 2017
Fix scripted tests to run conditionally
1 parent 2522d6d commit 5ddcabb

File tree

31 files changed

+50
-39
lines changed

31 files changed

+50
-39
lines changed
 

‎.travis.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ env:
77
- TRAVIS_NODE_VERSION="8"
88
matrix:
99
include:
10-
- env: SBT_VERSION="0.13.16"
11-
- env: SBT_VERSION="1.0.1"
10+
- env: TRAVIS_SBT_VERSION="0.13.16"
11+
- env: TRAVIS_SBT_VERSION="1.0.1"
1212
before_install:
1313
# Install Node.js and yarn.
1414
- nvm install 6
@@ -17,7 +17,7 @@ before_install:
1717
- curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 0.24.6
1818
- export PATH=$HOME/.yarn/bin:$PATH
1919
script:
20-
- sbt -no-colors ";^^$SBT_VERSION;test;scripted"
20+
- sbt -no-colors ";^^$TRAVIS_SBT_VERSION;test;runScripted"
2121
cache:
2222
directories:
2323
- $HOME/.ivy2/cache

‎build.sbt

+24
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,17 @@
11
import sbtunidoc.Plugin.ScalaUnidoc
22
import sbtunidoc.Plugin.UnidocKeys.unidoc
33

4+
val runScripted = taskKey[Unit]("Run supported sbt scripted tests")
5+
46
val `sbt-scalajs-bundler` =
57
project.in(file("sbt-scalajs-bundler"))
68
.settings(commonSettings: _*)
79
.settings(
810
sbtPlugin := true,
11+
runScripted := filterScripted {
12+
case "0.13" => Nil
13+
case "1.0" => Nil
14+
}.value,
915
name := "sbt-scalajs-bundler",
1016
description := "Module bundler for Scala.js projects",
1117
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.19")
@@ -16,6 +22,10 @@ val `sbt-web-scalajs-bundler` =
1622
.settings(commonSettings: _*)
1723
.settings(
1824
sbtPlugin := true,
25+
runScripted := filterScripted {
26+
case "0.13" => Nil
27+
case "1.0" => Seq(_ / "sbt-web-scalajs-bundler" * "play")
28+
}.value,
1929
scriptedDependencies := {
2030
val () = scriptedDependencies.value
2131
val () = publishLocal.value
@@ -141,3 +151,17 @@ lazy val noPublishSettings =
141151
publish := (),
142152
publishLocal := ()
143153
)
154+
155+
def filterScripted(excludeF: PartialFunction[String, Seq[File => PathFinder]]) = Def.taskDyn {
156+
val base = sbtTestDirectory.value
157+
val allTests = base * AllPassFilter * AllPassFilter filter { _.isDirectory }
158+
val exclude = excludeF((sbtBinaryVersion in pluginCrossBuild).value)
159+
val tests = exclude.map(_.apply(base)).foldLeft(allTests)(
160+
(remaining, excluded) => remaining --- excluded).get
161+
def args = tests.map(Path.relativeTo(base)).flatten.mkString(" ")
162+
163+
if (tests.nonEmpty)
164+
Def.task(scripted.toTask(" " + args).value)
165+
else
166+
Def.task(streams.value.log.warn("No tests can be run for this sbt version"))
167+
}

‎manual/src/ornate/getting-started.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % "{{version}}")
1111
~~~
1212

1313
> {.note}
14-
> Note that the plugin requires Scala.js 0.6.18+.
14+
> Note that the plugin requires Scala.js 0.6.18+ for sbt 0.13 and
15+
> Scala.js 0.6.19 for sbt 1.0.
1516
1617
Enable the `ScalaJSBundlerPlugin`, in your `build.sbt` file:
1718

‎sbt-scalajs-bundler/src/sbt-test/sbt-scalajs-bundler/additonalNpmConfig/project/build.properties

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.18")
1+
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.19")
22

33
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % sys.props.getOrElse("plugin.version", sys.error("'plugin.version' environment variable is not set")))

‎sbt-scalajs-bundler/src/sbt-test/sbt-scalajs-bundler/browserless/project/build.properties

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.18")
1+
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.19")
22

33
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % sys.props.getOrElse("plugin.version", sys.error("'plugin.version' environment variable is not set")))

‎sbt-scalajs-bundler/src/sbt-test/sbt-scalajs-bundler/facade-examples/project/build.properties

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.18")
1+
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.19")
22

33
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % sys.props.getOrElse("plugin.version", sys.error("'plugin.version' environment variable is not set")))

‎sbt-scalajs-bundler/src/sbt-test/sbt-scalajs-bundler/facade/project/build.properties

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.18")
1+
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.19")
22

33
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % sys.props.getOrElse("plugin.version", sys.error("'plugin.version' environment variable is not set")))

‎sbt-scalajs-bundler/src/sbt-test/sbt-scalajs-bundler/global-namespace-with-jsdom-unit-testing/project/build.properties

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.18")
1+
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.19")
22

33
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % sys.props.getOrElse("plugin.version", sys.error("'plugin.version' environment variable is not set")))

‎sbt-scalajs-bundler/src/sbt-test/sbt-scalajs-bundler/global-namespace/project/build.properties

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.18")
1+
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.19")
22

33
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % sys.props.getOrElse("plugin.version", sys.error("'plugin.version' environment variable is not set")))
44

5-
libraryDependencies += "net.sourceforge.htmlunit" % "htmlunit" % "2.23"
5+
libraryDependencies += "net.sourceforge.htmlunit" % "htmlunit" % "2.23"

‎sbt-scalajs-bundler/src/sbt-test/sbt-scalajs-bundler/js-resources/project/build.properties

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.18")
1+
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.19")
22

33
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % sys.props.getOrElse("plugin.version", sys.error("'plugin.version' environment variable is not set")))

‎sbt-scalajs-bundler/src/sbt-test/sbt-scalajs-bundler/library/project/build.properties

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.18")
1+
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.19")
22

33
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % sys.props.getOrElse("plugin.version", sys.error("'plugin.version' environment variable is not set")))
44

5-
libraryDependencies += "net.sourceforge.htmlunit" % "htmlunit" % "2.23"
5+
libraryDependencies += "net.sourceforge.htmlunit" % "htmlunit" % "2.23"

‎sbt-scalajs-bundler/src/sbt-test/sbt-scalajs-bundler/sharedconfig/project/build.properties

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.18")
1+
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.19")
22

33
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % sys.props.getOrElse("plugin.version", sys.error("'plugin.version' environment variable is not set")))
44

5-
libraryDependencies += "net.sourceforge.htmlunit" % "htmlunit" % "2.23"
5+
libraryDependencies += "net.sourceforge.htmlunit" % "htmlunit" % "2.23"

‎sbt-scalajs-bundler/src/sbt-test/sbt-scalajs-bundler/static-webpack2/project/build.properties

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.18")
1+
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.19")
22

33
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % sys.props.getOrElse("plugin.version", sys.error("'plugin.version' environment variable is not set")))
44

5-
libraryDependencies += "net.sourceforge.htmlunit" % "htmlunit" % "2.23"
5+
libraryDependencies += "net.sourceforge.htmlunit" % "htmlunit" % "2.23"

‎sbt-scalajs-bundler/src/sbt-test/sbt-scalajs-bundler/static/project/build.properties

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.18")
1+
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.19")
22

33
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % sys.props.getOrElse("plugin.version", sys.error("'plugin.version' environment variable is not set")))
44

5-
libraryDependencies += "net.sourceforge.htmlunit" % "htmlunit" % "2.23"
5+
libraryDependencies += "net.sourceforge.htmlunit" % "htmlunit" % "2.23"

‎sbt-scalajs-bundler/src/sbt-test/sbt-scalajs-bundler/transitive/project/build.properties

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.18")
1+
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.19")
22

33
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % sys.props.getOrElse("plugin.version", sys.error("'plugin.version' environment variable is not set")))

‎sbt-scalajs-bundler/src/sbt-test/sbt-scalajs-bundler/webpack-dev-server/project/build.properties

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.18")
1+
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.19")
22

33
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % sys.props.getOrElse("plugin.version", sys.error("'plugin.version' environment variable is not set")))
44

5-
libraryDependencies += "net.sourceforge.htmlunit" % "htmlunit" % "2.27"
5+
libraryDependencies += "net.sourceforge.htmlunit" % "htmlunit" % "2.27"

‎sbt-scalajs-bundler/src/sbt-test/sbt-scalajs-bundler/yarn-interactive/project/build.properties

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.18")
1+
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.19")
22

3-
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % sys.props.getOrElse("plugin.version", sys.error("'plugin.version' environment variable is not set")))
3+
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % sys.props.getOrElse("plugin.version", sys.error("'plugin.version' environment variable is not set")))

0 commit comments

Comments
 (0)
Please sign in to comment.