Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback from Sam Halliday #559

Closed
2 of 6 tasks
olafurpg opened this issue Jan 18, 2018 · 3 comments
Closed
2 of 6 tasks

Feedback from Sam Halliday #559

olafurpg opened this issue Jan 18, 2018 · 3 comments

Comments

@olafurpg
Copy link
Contributor

olafurpg commented Jan 18, 2018

Before I forget, feedback from @fommil on gitter https://gitter.im/scalacenter/scalafix?at=5a60da3bce68c3bc74d3d282

Some of these are duplicates to existing issues

  • ability to ignore generated (expanded macros) code, sbt-scalafix
  • ignore imports for Disable and DisableUnless, cc/ @vovapolu
  • better config format for DisableUnless
  • canonical way to add scalafix to alternative test configs
  • output in sbt should look exactly like scalac output, including [error] gutter
  • support exclude / include format in symbol lists (disable and disableunless). e.g. exclude "scala" (and its children) but then allow "scala.Int"
@fommil
Copy link
Contributor

fommil commented Jan 18, 2018

final two are

@MasseGuillaume MasseGuillaume changed the title Feedback from Sam Feedback from Sam Halliday Jan 18, 2018
@MasseGuillaume
Copy link
Contributor

MasseGuillaume commented Jan 18, 2018

I renamed to Feedback from Sam Halliday to avoid confusion with the Single Abstract Mehod (SAM) rule :P.

@fommil
Copy link
Contributor

fommil commented Feb 13, 2018

I broke everything out into separate tickets to track what is and isn't part of a potential final 2 weeks of sponsorship.

@fommil fommil closed this as completed Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants