Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Bloop launcher for Scala 2.13 #1295

Closed
olafurpg opened this issue May 28, 2020 · 9 comments
Closed

Publish Bloop launcher for Scala 2.13 #1295

olafurpg opened this issue May 28, 2020 · 9 comments

Comments

@olafurpg
Copy link
Contributor

Currently, the Bloop launcher is only available for Scala 2.12. It would be nice if the launcher was also available for 2.13 so that downstream applications like Metals can upgrade to 2.13 even if the Bloop server runs on 2.12.

@jvican
Copy link
Contributor

jvican commented Jun 2, 2020

Thanks for the feature request. How urgent is this?

@olafurpg
Copy link
Contributor Author

olafurpg commented Jun 2, 2020

It's not urgent at all. I just wanted to open an issue to track this since I saw there wasn't any related open ticket. Feel free to close if you prefer, I will work on this myself if it becomes urgent.

@jastice
Copy link
Contributor

jastice commented Aug 31, 2020

Now that we changed the IntelliJ Scala plugin to 2.13, this suddenly became relevant for us :D

@keynmol
Copy link
Collaborator

keynmol commented Sep 16, 2020

Can I help with this?

If I understand correctly all the module dependencies of launcher need to be made into cross-builds, and dependencies fixed (like with snailgun) or updated.

There's one bigger problem though - case-app from frontend is quite old and not published for 2.13, and newer versions have a dramatically different API (plus they're published under @alexarchambault's name - is this the same case-app?)

I've started cross-publishing work here: https://github.com/scalacenter/bloop/compare/master...keynmol:launcher-2.13?expand=1#diff-0ecdbc5a001d52fb34f5eafb7cd1aaa6R56

@jvican
Copy link
Contributor

jvican commented Sep 17, 2020

@keynmol Hey Anton, it'd be great if you can help cross-compiling the launcher to Scala 2.13. Given that upgrading the whole project to Scala 2.13 is going to be a difficult and a performance-sensitive task, I prefer to do it myself since I'll likely need to run some performance checks (there are lots of changes in latest Monix versions that affect us in complicated ways). However, the launcher is not performance sensitive and any help there is appreciated.

@ckipp01
Copy link
Member

ckipp01 commented Dec 6, 2020

Hey @keynmol! Were you still planning on tackling this?

@keynmol
Copy link
Collaborator

keynmol commented Dec 6, 2020

Hey @ckipp01!

I was waiting for snailgun to be published, but the case-app yak is much bigger and harder to shave (launcher needs frontend for tests, and frontend depended on a very old version of case-app not published for 2.13).

I've opened a draft PR where I've started the conversion: #1425

So if you can provide advice on how to convert the rest of the old case-app models to newer version - it will help move things along :)

@ckipp01
Copy link
Member

ckipp01 commented Dec 6, 2020

So if you can provide advice on how to convert the rest of the old case-app models to newer version - it will help move things along :)

😬 sorry, I'm really not the person to ask for this as I'm also pretty unfamiliar with the Bloop code base. With that said, I also played around with seeing what was needed for the case app update and also hit on some pretty large roadblocks like you have. As you'd expect, it's changed a lot in the past 3 years, and I'm assuming the version that is currently being used was a forked/published version. I don't see it listed anywhere under the Scala Center repos, so I have no idea what may have changed in that forking, or if that's even what happened.

I see that you've put the case app update on top of the other stuff, and again, totally not my call, but maybe consider doing that update as a standalone update. It may be easier to review that as a separate pr first to update case app, and then put everything else needed for the cross to 2.13 in another pr. My guess is that anything to help the current maintainers review this in chunks will be much appreciated.

@tgodzik
Copy link
Contributor

tgodzik commented Feb 22, 2022

The launcher is now published thanks to @kpodsiad !

@tgodzik tgodzik closed this as completed Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants