Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inliner heuristics: improve looksLikeForwarderOrFactoryOrTrivial #565

Open
lrytz opened this issue Oct 5, 2018 · 0 comments
Open

Inliner heuristics: improve looksLikeForwarderOrFactoryOrTrivial #565

lrytz opened this issue Oct 5, 2018 · 0 comments

Comments

@lrytz
Copy link
Member

lrytz commented Oct 5, 2018

looksLikeForwarderOrFactoryOrTrivial identifies forwarders, factories and trivial methods. Currently that method doesn't know a field read or a method call targets a public or private field or method. It approximates this by trating getfield as private, getstatic as public, invokespecial as private, invokestatic as public.

So we should fix the following miscategorizations:

  • should exclude forwarders that use invokestatic to call a private method (such forwarders should not be inlined, as this creates more private callsites, which should be avoided)
  • should include methods that read a public (non-static) field (such a method can be inlined. currently field accessors are excluded)
  • should exclude methods that read a private static field (should not be inlined).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants