Do not select versions with a hyphen #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... if the current version does not contain one. This is similar to #1134. `selectNext` currently allows these updates: ``` org.specs2:specs2-core:test : 4.5.1 -> 4.5.1-924020314 io.monix:monix-catnap : 3.1.0 -> 3.1.0-2156c0e io.monix:monix : 3.0.0 -> 3.0.0-ec266e1 com.lihaoyi:ammonite : 1.6.7 -> 1.6.7-2-c28002d com.lihaoyi:ammonite-ops : 1.6.6 -> 1.6.6-10-5fa74ab com.lightbend.paradox:sbt-paradox-project-info : 1.1.3 -> 9-6845d95d commons-httpclient:commons-httpclient : 2.0.2 -> 2.0-dev.20020705.071400 org.specs2:specs2-core : 4.2.0 -> 4.2.0-add90d25e-20180428143534 ``` All of these look like a transition from a release version to a dynamic version except that these version numbers don't use `+` but a `-` to separate the dynamic part from the release version.
Codecov Report
@@ Coverage Diff @@
## master #1148 +/- ##
==========================================
+ Coverage 69.74% 69.78% +0.04%
==========================================
Files 93 93
Lines 1408 1410 +2
Branches 34 34
==========================================
+ Hits 982 984 +2
Misses 426 426
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... if the current version does not contain one. This is similar to
#1134.
selectNextcurrently allows these updates:All of these look like a transition from a release version to a dynamic
version except that these version numbers don't use
+but a-toseparate the dynamic part from the release version.