Does not work with Solidity v0.8 "unchecked" blocks

[PaulRBerg]

Description

Solidity v0.8 introduced checked and unchecked arithmetic.

I recently noticed that none of the code wrapped in my unchecked blocks is analysed by solidity-coverage. For instance, look at line #149 in Coveralls build no. 38616686 of my prb-math repo:

None of the code inside is highlighted to reflect whether my tests hit those lines or not. In fact, I know of one line that definitely hasn't been reached by my tests, that is line #230 (and presumably this is also true of some of the many if branches in there).

Environment

• hardhat@2.1.1
• prb-math@f49d787
• solidity-coverage@0.7.16
• solidity@0.8.3

[cgewecke]

@PaulRBerg Yes, makes sense. We need to add unchecked to the parse table and process it like other code blocks.

Thanks for reporting.

[PaulRBerg]

Hey @cgewecke, is there any we could help you speed up development on this?

You may have heard about the Gitcoin Grants programme. You basically set up a profile, link it on GitHub and social media, then people can donate ETH and ERC-20 tokens.

I, and I'm sure many others too, would be happy to contribute to your grant.

[cgewecke]

@PaulRBerg Ah! Really sorry, this fell through cracks.... will look at this ASAP (and fix a few other things here)

Will look at grants, thanks!

[PaulRBerg]

Awesome.

[cgewecke]

This is finally fixed in 0.7.17

[PaulRBerg]

I'm using solidity-coverage v0.7.20 and it looks like unchecked blocks have stopped being covered.

This is with Hardhat v2.8.4 and Solidity v0.8.12.

[cgewecke]

Ok, weird.... I'll look at this again. Need to add a test for this syntax.

[cgewecke]

This is fixed in 0.7.21 (for real :) )

[PaulRBerg]

Amazing, thank you!