files not skipped on windows

[RyanHubs]

Hi,
I got an issue when running coverage on windows.
Should I convert a windows path to posix path?

version: solidity-coverage@0.7.2
system: win10 x64

.solcover.js: 
module.exports = {
    skipFiles:        ["./common/EIP712.sol"],
    istanbulFolder:   "./doc/coverage/",
    istanbulReporter: ["html"],
};

code: solidity-coverage/plugins/resources/plugin.utils.js line142
function assembleTargets(config, targets=[], skipFiles=[]){
  const skipped = [];
  const filtered = [];
  const cd = config.contractsDir;

  for (let target of targets){
    if (skipFiles.includes(target)){

      skipped.push({
        canonicalPath: target,
        relativePath: toRelativePath(target, cd),
        source: loadSource(target)
      })

    } else {

      filtered.push({
        canonicalPath: target,
        relativePath: toRelativePath(target, cd),
        source: loadSource(target)
      })
    }
  }

  console.log(`targets:${JSON.stringify(targets)}`)
  console.log(`skipFiles:${JSON.stringify(skipFiles)}`)
  return {
    skipped: skipped,
    targets: filtered
  }
}
log:
targets:["C:/common/contracts/common/EIP712.sol",
             "C:/common/contracts/Migrations.sol"]
skipFiles:["C:\\common\\contracts\\common\\EIP712.sol",
               "C:\\common\\contracts\\Migrations.sol"]

[cgewecke]

@RyanHubs Thanks for reporting. I don't have windows box ... could you help test a solution?

If you modify this:

solidity-coverage/plugins/resources/plugin.utils.js

Line 135 in 67ca4b4

const targets = shell.ls(targetsPath);

..to this, does that fix it?

const targets = shell.ls(targetsPath).map(path.normalize);

[RyanHubs]

Thank you for your quick reply,
I have verified that the modification can get the correct result.

[AleG94]

When is it going to be released? I'm currently stuck between this and #481.
I can't parse the file nor exclude it from coverage.

[cgewecke]

@AleG94 Apologies, I will publish again today.

[cgewecke]

Published with 0.7.3