Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watcharr doesn't found this movie: "Domingo Domingo" #531

Closed
simonbcn opened this issue May 29, 2024 · 2 comments · Fixed by #562
Closed

Watcharr doesn't found this movie: "Domingo Domingo" #531

simonbcn opened this issue May 29, 2024 · 2 comments · Fixed by #562
Assignees
Labels
bug Hmm, this isn't working correctly
Milestone

Comments

@simonbcn
Copy link

Watcharr v1.39.0 running on Docker

When I search for the movie "Domingo Domingo", Watcharr doesn't show that movie:
Captura de pantalla 2024-05-29 a las 13 33 53

In fact, I would say that there is a problem with the search results because if I put only "Sunday" it shows this:
Captura de pantalla 2024-05-29 a las 13 36 53

@IRHM
Copy link
Member

IRHM commented May 29, 2024

Hi, sorry you're having this problem.

I think this is because we only show the first page of results, but TMDB seems to show a bunch of people in the results instead of the movie with the exact name.

I believe this is the movie you're looking for? https://www.themoviedb.org/movie/874511-domingo-domingo

For now, you may have to directly visit it in your watcharr instance by id in url: 874511

https://beta.watcharr.app/movie/874511

(Replacing beta.watcharr.app with your servers hostname/address).

I will look into this when I get a chance, we will probably have to add support for pagination (showing next page results when scrolling down results).

Thanks for making this issue!

@IRHM IRHM added the bug Hmm, this isn't working correctly label May 29, 2024
@IRHM IRHM self-assigned this May 29, 2024
@IRHM IRHM moved this to Todo in Watcharr May 29, 2024
@IRHM IRHM added this to the v1.40 milestone May 29, 2024
@IRHM IRHM moved this from Todo to In Progress in Watcharr Jun 13, 2024
@IRHM IRHM modified the milestones: v1.40, v1.41 Jun 22, 2024
@IRHM
Copy link
Member

IRHM commented Jun 24, 2024

Support for infinite scrolling (pagination) has been added and I've reworked the movie/tv/people filter button at the top of results to always be shown and to perform a new request to the server to get all content of that type.

Both methods should work to help you find any piece of content you are looking for. I tested for this case, I can either scroll down until I see this movie, or I click the movies filter and see it right there.

Will be released soon!

@IRHM IRHM closed this as completed in #562 Jun 24, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Waiting Until Dev Build in Watcharr Jun 24, 2024
@IRHM IRHM moved this from Waiting Until Dev Build to Tested in Watcharr Jun 28, 2024
@IRHM IRHM moved this from Tested to Done in Watcharr Jun 28, 2024
truecharts-admin referenced this issue in truecharts/public Jun 28, 2024
….0@2229366 by renovate (#23905)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/sbondco/watcharr](https://togithub.com/sbondCo/Watcharr) |
minor | `v1.40.0` -> `v1.41.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>sbondCo/Watcharr (ghcr.io/sbondco/watcharr)</summary>

###
[`v1.41.0`](https://togithub.com/sbondCo/Watcharr/releases/tag/v1.41.0)

[Compare
Source](https://togithub.com/sbondCo/Watcharr/compare/v1.40.0...v1.41.0)

#### 🧠 New

- Search: Infinite scrolling and serverside content type filters by
[@&#8203;IRHM](https://togithub.com/IRHM) in
[https://github.com/sbondCo/Watcharr/pull/562](https://togithub.com/sbondCo/Watcharr/pull/562)
- Search now supports scrolling through multiple pages of results,
making it possible to find content that may have been hidden in the
past.
- The search filters (Movies, TV Shows, Games, People) have been
reworked to filter through the server, this leads to better results and
more of them.
- Running search requests will now be cancelled if you navigate away
from the page or if you change your search query (helps a lot on slower
connections).
- Ryot import implementation by
[@&#8203;oPisiti](https://togithub.com/oPisiti) in
[https://github.com/sbondCo/Watcharr/pull/563](https://togithub.com/sbondCo/Watcharr/pull/563)

#### 💯 Changed

- Time unit changes by [@&#8203;oPisiti](https://togithub.com/oPisiti)
in
[https://github.com/sbondCo/Watcharr/pull/563](https://togithub.com/sbondCo/Watcharr/pull/563)
    -   Movie/show runtimes are now printed as `24 min` instead of `24m`
- Time spent watching stats can now show `months, weeks, days, hours &
minutes`, instead of just the previous `hours and minutes`.

#### 🏗️ Fixed

- Fix server side rating validation for imports, watched episodes and
watched seasons in
sbondCo/Watcharr@7888e04

#### 🔨 Maintenance

- server: bump golang.org/x/crypto from 0.23.0 to 0.24.0 in /server by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/sbondCo/Watcharr/pull/539](https://togithub.com/sbondCo/Watcharr/pull/539)
- ui: bump prettier from 3.2.5 to 3.3.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/sbondCo/Watcharr/pull/549](https://togithub.com/sbondCo/Watcharr/pull/549)
- server: bump gorm.io/driver/sqlite from 1.5.5 to 1.5.6 in /server by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/sbondCo/Watcharr/pull/546](https://togithub.com/sbondCo/Watcharr/pull/546)
- workflow: bump docker/build-push-action from 5 to 6 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/sbondCo/Watcharr/pull/545](https://togithub.com/sbondCo/Watcharr/pull/545)
- ui: bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 7.12.0 to 7.14.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/sbondCo/Watcharr/pull/560](https://togithub.com/sbondCo/Watcharr/pull/560)
- ui: bump svelte-eslint-parser from 0.36.0 to 0.39.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/sbondCo/Watcharr/pull/559](https://togithub.com/sbondCo/Watcharr/pull/559)
- ui: bump eslint-plugin-svelte from 2.39.0 to 2.41.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/sbondCo/Watcharr/pull/558](https://togithub.com/sbondCo/Watcharr/pull/558)
- server: bump github.com/go-co-op/gocron/v2 from 2.5.0 to 2.7.0 in
/server by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/sbondCo/Watcharr/pull/557](https://togithub.com/sbondCo/Watcharr/pull/557)

#### 🥇 Credit

- Thanks to [@&#8203;oPisiti](https://togithub.com/oPisiti) for making
their first (and second) contribution in
[https://github.com/sbondCo/Watcharr/pull/563](https://togithub.com/sbondCo/Watcharr/pull/563)
- Thanks to [@&#8203;simonbcn](https://togithub.com/simonbcn) for
reporting an issue that led to the search improvements being made in
[https://github.com/sbondCo/Watcharr/issues/531](https://togithub.com/sbondCo/Watcharr/issues/531)

#### 🆘 Getting Help

If you need help, encounter an issue or find a bug please [create an
issue](https://togithub.com/sbondCo/Watcharr/issues/new/choose) or [join
our space on Matrix](https://matrix.to/#/#watcharr:matrix.org) for
support. Always happy to help!

I spent a lot of time trying to make sure no bugs were introduced with
the new search features, please don't hesitate to reach out if you think
someone is not working as intended!

Package:
https://github.com/orgs/sbondCo/packages/container/watcharr/236341139?tag=v1.41.0
or [on docker
hub](https://hub.docker.com/layers/sbondco/watcharr/v1.41.0/images/sha256-2229366989b906418c17df5a54c0c6d378f6044f45c591bba81a6cdd25e30a96?context=explore)
**Full Changelog**:
sbondCo/Watcharr@v1.40.0...v1.41.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Hmm, this isn't working correctly
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants