Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name conflict with other libraries for const String ERROR #19

Open
Pronoe opened this issue Mar 11, 2022 · 3 comments
Open

Name conflict with other libraries for const String ERROR #19

Pronoe opened this issue Mar 11, 2022 · 3 comments
Labels
keep don't stale this issue

Comments

@Pronoe
Copy link
Contributor

Pronoe commented Mar 11, 2022

Bootstrapper library uses a const STRING ERROR which is a very common name (définitions in Helpers.h, set value in Helspers.cpp, used in BootstrapManager.cpp and may be in the application code).
I am using also the ezTime library which use the same name ERROR in an enum list.
The compiler raises an error related to the reuse of an existing name, and this, whatever is the order of the #include directives of the 2 libraries.
I solved provisionally this issue by renaming ERROR in the Bootstrapper library but this make testing of the committed modifications more difficult.
I have now taken the option to modify the ERROR name in the ezTime library.
In both case, this is not clean.
Could you recommend a better solution as using namespace or anything else ?

@sblantipodi
Copy link
Owner

yes a namespace would be the best way to do it...

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label May 22, 2022
@sblantipodi sblantipodi removed the Stale label May 23, 2022
@sblantipodi sblantipodi added Stale keep don't stale this issue and removed Stale labels Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep don't stale this issue
Projects
None yet
Development

No branches or pull requests

2 participants