detect soap faults with http response code != 500

the soap specification is a joke. a couple of years developing this and i haven't found one server following the spec. reverting the check for an http response code 500.
savonrb · Feb 15, 2011 · 771194c · 771194c
1 parent de360a4
commit 771194c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/lib/savon/soap/fault.rb b/lib/savon/soap/fault.rb
@@ -19,7 +19,7 @@ def initialize(http)
 
       # Returns whether a SOAP fault is present.
       def present?
-        @present ||= http.code == 500 && http.body.include?("Fault>") && (soap1_fault? || soap2_fault?)
+        @present ||= http.body.include?("Fault>") && (soap1_fault? || soap2_fault?)
       end
 
       # Returns the SOAP fault message.

diff --git a/spec/savon/soap/fault_spec.rb b/spec/savon/soap/fault_spec.rb
@@ -32,11 +32,6 @@
     it "should return false unless the HTTP response contains a SOAP fault" do
       no_fault.should_not be_present
     end
-
-    it "should return false if the HTTP response code is not 500" do
-      fault = Savon::SOAP::Fault.new new_response(:code => 200, :body => Fixture.response(:soap_fault))
-      fault.should_not be_present
-    end
   end
 
   [:message, :to_s].each do |method|