DietSeurat doesn't drop layers from objects

[rharao]

(I have double-checked to confirm that DietSeurat is provided in Seurat and not SeuratObject.)

While working on a reprex to answer a question in another issue on this repo, I found out that each of the following calls:

• DietSeurat(pbmc_small, layers = "counts") # Only assay is "RNA"
• DietSeurat(pbmc_small, layers = "counts", assays = "RNA")
• DietSeurat(pbmc_small, layers = list(RNA = "counts"))

results in an object with all layers retained:

An object of class Seurat 
230 features across 80 samples within 1 assay 
Active assay: RNA (230 features, 20 variable features)
 3 layers present: counts, data, scale.data

Layers not mentioned in the layers argument to DietSeurat should be dropped from the result.

[samuel-marsh]

Hi,

Not member of dev team but hopefully can be helpful. This has been reported before (#8054 annd #8197) and hopefully fix can be implemented soon.

@dcollins15 hope you don’t mind me tagging you here. It would be great to have eyes on this from Seurat team as it seems like pretty straightforward fix.

Thanks,
Sam

[rharao]

Apologies for the duplicate issue!

[samuel-marsh]

No worries!

[rharao]

#8197 has been merged into develop.