Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

inline source map #372

Closed
jonathanong opened this issue Jul 23, 2014 · 16 comments
Closed

inline source map #372

jonathanong opened this issue Jul 23, 2014 · 16 comments

Comments

@jonathanong
Copy link

is there an option for inlining the sourcemap?

@scottmas
Copy link

This would be very nice

@10xLaCroixDrinker
Copy link
Contributor

You could always just do what gulp-sass does

@nschonni
Copy link
Contributor

@jonathanong No, it looks like it coming in the next reference version of Sass sass/sass@dd48bb9, but I don't think the option should be added till after that.

@jking90 that would be a good approach till libsass supports it natively.

@mchambaud
Copy link

Any news on this?

@keithamus
Copy link
Member

@mchambaud @jonathanong @scottmas since the new version of libsass has been released, we'll be updating very shortly. It takes some time to make a release but feel free to follow #443 for updates. I'll keep this issue open as some work will need to be done to support it. If any of you fancy taking a crack at a PR that'd be fantastic!

@nschonni
Copy link
Contributor

nschonni commented Oct 3, 2014

@keithamus libsass still hasn't implemented inline sourcemaps yet

@mchambaud
Copy link

@keithamus @nschonni I created a new issue with libsass to have it implemented.

sass/libsass#498

@chrisspiegl
Copy link

+1

@am11
Copy link
Contributor

am11 commented Oct 27, 2014

@jking90, just saw the code you pointed out.

Apparently they can use omitSourceMapUrl option and remove that hack. :)

@am11
Copy link
Contributor

am11 commented Nov 3, 2014

Just to give you guys heads-up; this feature is under development in libsass. See sass/libsass#603 and sass/libsass#605. We would need thorough testing (preferably comparable to less.js). If you guys want to chime in, please submit test cases to sass-spec; especially those covering complex import scenarios.

Thanks.

@mgreter
Copy link
Contributor

mgreter commented Nov 3, 2014

This is actually already implemented. The open PR is about adding more mapping information the the source maps. Embeding source maps and inlining source contents was implement in sass/libsass#591.

+ // embed include contents in maps
+ bool source_map_contents;
+ // embed sourceMappingUrl as data uri
+ bool source_map_embed;

By setting both options to true you should get a completely self-contained source-map.

@kevva
Copy link
Member

kevva commented Nov 3, 2014

👍, so we just need to add it here.

@am11
Copy link
Contributor

am11 commented Nov 3, 2014

@kevva, Yup! but we would probably have to wait for tagged release.. 😄
@mgreter, thanks! 👍 I will find some time to add tests on sass-spec. Or shall we (can we / should we) add that sort of tests in sassc repo?

@am11
Copy link
Contributor

am11 commented Nov 18, 2014

This is added by d58c303 via #543.

See #543 (comment).

@am11
Copy link
Contributor

am11 commented Nov 18, 2014

On that note; our documentation (readme) is quite outdated now.
A lot has changed since it was last updated..

@am11 am11 added the v2 label Dec 24, 2014
@am11
Copy link
Contributor

am11 commented Dec 24, 2014

Inline source-map feature has arrived with v2.0.0-beta. See README and [release notes](v2.0.0-beta is just released.

@am11 am11 closed this as completed Dec 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

10 participants