-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup arm64 linux/windows runners for AOT releases #2259
Comments
For windows, don't we have to build a script snapshot anyway to avoid code signing issues? |
As long as we're not building self-contained exe, there is no code sign issue. The production release of Our windows x64 release is currently AOT. |
I believe all you'd need to do to get these runners going is declare them in the actions file—they should pull from the same spending pool as the existing paid runners. |
These arm runners are not public free tier, which need to be created first via https://github.com/organizations/sass/settings/actions/runners, and then it can be specified with the name define during creation. |
All right, I've created runners named |
https://github.blog/2024-06-03-arm64-on-github-actions-powering-faster-more-efficient-build-systems/
Specifically this can address the following:
dart-sass/.github/workflows/build-linux-musl.yml
Lines 23 to 28 in 5ddd7fc
It allows us to build AOT for linux-arm-musl directly, as QEMU wasn't working. The Ampere CPU used by GitHub hosted runners is compatible with 32-bit arm. We can also build arm64 on arm64 runners instead of QEMU, which can speed up the build.
dart-sass/.github/workflows/build-windows.yml
Lines 21 to 22 in 5ddd7fc
It allows us to build aot for windows-arm64.
@nex3 These would require setting up two paid runners, one for linux and one for windows. As we did setup a paid macos runner in the past, is this something you can help look into?
The text was updated successfully, but these errors were encountered: