Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

unify macro names for setting motor positions and limits #1641

Open
dschick opened this issue Jul 7, 2021 · 2 comments
Open

unify macro names for setting motor positions and limits #1641

dschick opened this issue Jul 7, 2021 · 2 comments
Labels
enhancement macro:builtin built in macros related issues

Comments

@dschick
Copy link

dschick commented Jul 7, 2021

currently the naming of the macros for setting the positions and limits for motors are not consistent and might have some historic links to SPEC.

positon: set_pos and set_user_pos
limits: set_lm and set_lim

I would suggest to introduce the following aliases:
set_dial_lim --> set_lm
set_user_lim --> set_lim
set_dial_pos --> set_pos
set_user_pos is okay

let me know what you think

@dschick dschick changed the title unify naming for motor positions and limits unify macro names for setting motor positions and limits Jul 7, 2021
@reszelaz reszelaz added enhancement macro:builtin built in macros related issues labels Jul 10, 2021
@reszelaz
Copy link
Collaborator

Hi @dschick,

I personally like this idea. Let's see if there are other opinions.
Regarding the implementation I just checked and the following works:

class set_user_lim(set_lm):
    pass

Were you thinking about a different implementation?

@reszelaz
Copy link
Collaborator

BTW, there is this issue about the user and dial limits: #159. I'm not sure if what we wrote at that time is actually right. It would be good if you could comment there on the relations between the dial and user limits, as well as about the re-calculation of the limits whenever the position-related attributes (step_per_unit, offset, and sign) change.
Many thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement macro:builtin built in macros related issues
Projects
None yet
Development

No branches or pull requests

2 participants