Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of Stock Product throws exception when selection options #50

Open
imrankhanjoya opened this issue Sep 22, 2019 · 5 comments
Open

Out of Stock Product throws exception when selection options #50

imrankhanjoya opened this issue Sep 22, 2019 · 5 comments
Labels
Priority: High Important task Status: On Hold No current development going on Type: Bug Something isn't working

Comments

@imrankhanjoya
Copy link

imrankhanjoya commented Sep 22, 2019

Describe the bug
App crash while selecting size on a configurable product which is out of stock.
reason: quantity value from server is not handled correctly in code

Expected behavior

  1. In case of configurable product, particular option which is out of stock should be disabled from selection
  2. In case of simple product, add to cart button should be disabled and message should be displayed out of stock on the screen.

Current Behavior
App crash
Screen Shot 2019-09-22 at 12 36 00 PM

@imrankhanjoya imrankhanjoya added the Type: Bug Something isn't working label Sep 22, 2019
@sanjeevyadavIT
Copy link
Owner

Please give more context?

  1. Are you suing default store url or your own custom magento url?
  2. If you are using default store url, could you point out the which product you are opening?

@imrankhanjoya
Copy link
Author

http://fiji.jaipurshine.com/summer-women-s-striped-dress-short-sleeve-off-shoulder-slim-sexy-long-dress-for-women.html
This happens when product is out of stock and also don't see quantity option.

Thanks

@sanjeevyadavIT
Copy link
Owner

thanks for pointing that out, I haven't implemented this out of stock check in the code, currently the app is very basic and need to be refined at so many levels. If you are interested in contributing I will be happy to help you out.

@sanjeevyadavIT sanjeevyadavIT changed the title Issue while selecting option for size attached screen? Out of Stock Product throws exception when selection options Sep 22, 2019
@sanjeevyadavIT sanjeevyadavIT added Priority: High Important task Status: On Hold No current development going on labels Sep 22, 2019
@sanjeevyadavIT sanjeevyadavIT removed their assignment Oct 21, 2019
@sanjeevyadavIT sanjeevyadavIT pinned this issue Oct 21, 2019
@sanjeevyadavIT
Copy link
Owner

@all-contributors please add imrankhanjoya for bug

@allcontributors
Copy link
Contributor

@alexakasanjeev

I've put up a pull request to add @imrankhanjoya! 🎉

@sanjeevyadavIT sanjeevyadavIT unpinned this issue Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Important task Status: On Hold No current development going on Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants