Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y25-107 - Migrate & Improve GitHub Actions - Limber #2216

Open
8 tasks
SHIV5T3R opened this issue Feb 11, 2025 · 0 comments
Open
8 tasks

Y25-107 - Migrate & Improve GitHub Actions - Limber #2216

SHIV5T3R opened this issue Feb 11, 2025 · 0 comments
Labels
Size: S Small - low effort & risk Technical Debt

Comments

@SHIV5T3R
Copy link
Member

Describe the Housekeeping
As a part of the parent story, the workflows for Limber can be migrated to shared workflows and improved upon.

Workflows to migrate


  • compile_test.yml - This will test the build, then dry-run a new release. It could be worth migrating this to a shared workflow and using it in other repos?

  • lint.yml - This runs rubocop, prettier, and ESLint. These will be split up into shared workflow steps and used here, separated by the different environments.

  • test_js.yml - This sets up node and runs yarn test, then uploads to code coverage. It can use the shared node setup workflow, the testing can also be a workflow. Code coverage should also be it's own shared workflow, as it's used in other repos.

  • test_ruby.yml - This runs the ruby and limber setup, both of which can be shared workflows. The rpsec tests can also be it's own shared workflow, these are used in Sequencescape and Traction Service.

  • update_rubocop.yml - Can be migrated to a workflow, it's used in Sequencescape.

Potential improvements
Setup any environments (node/bundle) an cache them. These cached instances can then be used, being relied on by each step, so that the instance is only created once. This also includes the bin/setup that Limber uses.

Related issues

Additional context
For the second set of workflows, they can be split by their respective environments and the environment setup can be done once for each, similar to how it can be done in Sequencescape.

@SHIV5T3R SHIV5T3R added Size: S Small - low effort & risk Technical Debt labels Feb 11, 2025
@psd-issuer psd-issuer bot changed the title Migrate & Improve GitHub Actions - Limber Y25-107 - Migrate & Improve GitHub Actions - Limber Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: S Small - low effort & risk Technical Debt
Projects
None yet
Development

No branches or pull requests

1 participant