You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
compile_test.yml - This will test the build, then dry-run a new release. It could be worth migrating this to a shared workflow and using it in other repos?
lint.yml - This runs rubocop, prettier, and ESLint. These will be split up into shared workflow steps and used here, separated by the different environments.
test_js.yml - This sets up node and runs yarn test, then uploads to code coverage. It can use the shared node setup workflow, the testing can also be a workflow. Code coverage should also be it's own shared workflow, as it's used in other repos.
test_ruby.yml - This runs the ruby and limber setup, both of which can be shared workflows. The rpsec tests can also be it's own shared workflow, these are used in Sequencescape and Traction Service.
update_rubocop.yml - Can be migrated to a workflow, it's used in Sequencescape.
Potential improvements
Setup any environments (node/bundle) an cache them. These cached instances can then be used, being relied on by each step, so that the instance is only created once. This also includes the bin/setup that Limber uses.
Additional context
For the second set of workflows, they can be split by their respective environments and the environment setup can be done once for each, similar to how it can be done in Sequencescape.
The text was updated successfully, but these errors were encountered:
Describe the Housekeeping
As a part of the parent story, the workflows for Limber can be migrated to shared workflows and improved upon.
Workflows to migrate
append_release.yml
- This should be a shared workflow, it is also used in Sequencescape.automated_release.yml
- This needs to use a shared workflow, it will be made because other repositories use this too.check_release_version.yml
- Use the shared workflow version of this, it's used everywhere.compile_test.yml
- This will test the build, then dry-run a new release. It could be worth migrating this to a shared workflow and using it in other repos?lint.yml
- This runs rubocop, prettier, and ESLint. These will be split up into shared workflow steps and used here, separated by the different environments.test_js.yml
- This sets up node and runs yarn test, then uploads to code coverage. It can use the shared node setup workflow, the testing can also be a workflow. Code coverage should also be it's own shared workflow, as it's used in other repos.test_ruby.yml
- This runs the ruby and limber setup, both of which can be shared workflows. The rpsec tests can also be it's own shared workflow, these are used in Sequencescape and Traction Service.update_rubocop.yml
- Can be migrated to a workflow, it's used in Sequencescape.Potential improvements
Setup any environments (node/bundle) an cache them. These cached instances can then be used, being relied on by each step, so that the instance is only created once. This also includes the bin/setup that Limber uses.
Related issues
Additional context
For the second set of workflows, they can be split by their respective environments and the environment setup can be done once for each, similar to how it can be done in Sequencescape.
The text was updated successfully, but these errors were encountered: