From e82ea5ad8370069a3d0f77e15f6ea246b75b4bf1 Mon Sep 17 00:00:00 2001 From: Leon Dies Date: Wed, 18 May 2022 17:57:21 +0200 Subject: [PATCH] TASK: Remove unused test case --- .../Eel/Helper/CookiePunchConfigTest.php | 25 +++++-------------- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/Tests/Functional/Eel/Helper/CookiePunchConfigTest.php b/Tests/Functional/Eel/Helper/CookiePunchConfigTest.php index de4fc99..b2374f4 100644 --- a/Tests/Functional/Eel/Helper/CookiePunchConfigTest.php +++ b/Tests/Functional/Eel/Helper/CookiePunchConfigTest.php @@ -41,10 +41,10 @@ public function initDummySiteNode() { */ public function validEelExpressionIsEvaluatedCorrectly() { - $conditionalServiceRendering = new CookiePunchConfig(); + $cookiePunchConfig = new CookiePunchConfig(); $eelExpression = '${1 + 1 == 2}'; - $actual = $conditionalServiceRendering->evaluateEelExpression($eelExpression, $this->dummySiteNode); + $actual = $cookiePunchConfig->evaluateEelExpression($eelExpression, $this->dummySiteNode); self::assertTrue($actual, "Not a valid eel expression: " . $eelExpression); } @@ -56,23 +56,10 @@ public function invalidEelExpressionThrowsException() { self::expectExceptionMessage('Invalid eel expression in CookiePunch config service block. Given: ${1 + 1 == 2'); - $conditionalServiceRendering = new CookiePunchConfig(); + $cookiePunchConfig = new CookiePunchConfig(); $eelExpression = '${1 + 1 == 2'; - $conditionalServiceRendering->evaluateEelExpression($eelExpression, $this->dummySiteNode); - } - - /** - * @test - */ - public function eelExpressionThatDoesNotResolveToBoolThrowsException() - { - self::expectExceptionMessage('An eel expression was used in CookiePunch config service block that does not resolve to boolean. Given: ${"hello"}'); - - $conditionalServiceRendering = new CookiePunchConfig(); - - $eelExpression = '${"hello"}'; - $conditionalServiceRendering->evaluateEelExpression($eelExpression, $this->dummySiteNode); + $cookiePunchConfig->evaluateEelExpression($eelExpression, $this->dummySiteNode); } /** @@ -82,11 +69,11 @@ public function eelExpressionThatDoesNotResolveToBoolThrowsException() */ public function testIfSitenodeIsPutCorrectlyIntoContext() { - $conditionalServiceRendering = new CookiePunchConfig(); + $cookiePunchConfig = new CookiePunchConfig(); $eelExpression = '${site != null}'; - $actual = $conditionalServiceRendering->evaluateEelExpression($eelExpression, $this->dummySiteNode); + $actual = $cookiePunchConfig->evaluateEelExpression($eelExpression, $this->dummySiteNode); self::assertTrue($actual, "Sitenode not found in context"); }