From c634b3782323a62202463b4e66935138cc9c7a1b Mon Sep 17 00:00:00 2001 From: Tom Johnson Date: Fri, 2 Mar 2018 13:38:25 -0800 Subject: [PATCH] Lock `simple_form` less strictly We previously supported `~> 3.2`. The regression introduced in v3.5.1 is described at https://github.com/plataformatec/simple_form/issues/1549. We'll need to fix our presenters to be `ActiveModel` compliant to make `simple_form` work correctly past that version. In the meanwhile, we shouldn't require any simple_form upgrade as part of an upcoming Hyrax release. --- hyrax.gemspec | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hyrax.gemspec b/hyrax.gemspec index 023df69e34..222a64fbb0 100644 --- a/hyrax.gemspec +++ b/hyrax.gemspec @@ -105,8 +105,9 @@ SUMMARY ######################################################## # Temporarily pinned dependencies. INCLUDE EXPLANATIONS. # - # simple_form 3.5.1 broke local and Travis builds in bad ways for unknown reasons - spec.add_dependency 'simple_form', '=3.5.0' + # simple_form 3.5.1 broke hydra-editor for certain model types; + # see: https://github.com/plataformatec/simple_form/issues/1549 + spec.add_dependency 'simple_form', '~> 3.2', '<= 3.5.0' # parser 2.5.0.0 broke local and Travis rubocop checks due to a change in parsing spec.add_development_dependency 'parser', '< 2.5' end