From cb6d7d53c79d3033e49093be5d8fe64a506e6329 Mon Sep 17 00:00:00 2001
From: lsat12357 <lsato@uoregon.edu>
Date: Thu, 31 Oct 2024 12:14:09 -0700
Subject: [PATCH 1/2] aria-label for button text alternative

---
 app/views/hyrax/file_sets/_permission_form.html.erb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/views/hyrax/file_sets/_permission_form.html.erb b/app/views/hyrax/file_sets/_permission_form.html.erb
index 93da4743a3..c0ceff68ca 100644
--- a/app/views/hyrax/file_sets/_permission_form.html.erb
+++ b/app/views/hyrax/file_sets/_permission_form.html.erb
@@ -33,7 +33,7 @@
         <%= select_tag 'new_user_permission_skel', options_for_select(configured_permission_options), class: 'form-control' %>
       </div>
       <div class="col-sm-3">
-        <button class="btn btn-secondary" id="add_new_user_skel">
+        <button class="btn btn-secondary" id="add_new_user_skel" aria-label="add this user">
           <span class="sr-only"><%= t('.add_new_user_skel', account_label: t('hyrax.account_label')) %></span>
           <span aria-hidden="true"><i class="fa fa-plus"></i></span>
         </button>
@@ -57,7 +57,7 @@
       </div>
       <div class="col-sm-3">
         <span class="sr-only"><%= t('.add_new_group_skel') %></span>
-        <button class="btn btn-secondary" id="add_new_group_skel"><i class="fa fa-plus"></i></button>
+        <button class="btn btn-secondary" id="add_new_group_skel" aria-label="add this group"><i class="fa fa-plus"></i></button>
         <br /><span id="directory_group_result"></span>
       </div>
     </div>

From b6e16603ae4be5813dc598a1fdf3b56ffdfa1f2a Mon Sep 17 00:00:00 2001
From: lsat12357 <lsato@uoregon.edu>
Date: Thu, 31 Oct 2024 13:35:13 -0700
Subject: [PATCH 2/2] put sr span inside button

---
 app/views/hyrax/file_sets/_permission_form.html.erb | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/app/views/hyrax/file_sets/_permission_form.html.erb b/app/views/hyrax/file_sets/_permission_form.html.erb
index c0ceff68ca..d804699e05 100644
--- a/app/views/hyrax/file_sets/_permission_form.html.erb
+++ b/app/views/hyrax/file_sets/_permission_form.html.erb
@@ -33,7 +33,7 @@
         <%= select_tag 'new_user_permission_skel', options_for_select(configured_permission_options), class: 'form-control' %>
       </div>
       <div class="col-sm-3">
-        <button class="btn btn-secondary" id="add_new_user_skel" aria-label="add this user">
+        <button class="btn btn-secondary" id="add_new_user_skel">
           <span class="sr-only"><%= t('.add_new_user_skel', account_label: t('hyrax.account_label')) %></span>
           <span aria-hidden="true"><i class="fa fa-plus"></i></span>
         </button>
@@ -56,8 +56,10 @@
         <%= select_tag 'new_group_permission_skel', options_for_select(configured_permission_options), class: 'form-control' %>
       </div>
       <div class="col-sm-3">
-        <span class="sr-only"><%= t('.add_new_group_skel') %></span>
-        <button class="btn btn-secondary" id="add_new_group_skel" aria-label="add this group"><i class="fa fa-plus"></i></button>
+        <button class="btn btn-secondary" id="add_new_group_skel">
+          <span class="sr-only"><%= t('.add_new_group_skel') %></span>
+          <i class="fa fa-plus"></i>
+        </button>
         <br /><span id="directory_group_result"></span>
       </div>
     </div>