Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New worthwhile form can't add/remove multi-values. #50

Closed
tpendragon opened this issue Dec 31, 2014 · 7 comments · Fixed by #51
Closed

New worthwhile form can't add/remove multi-values. #50

tpendragon opened this issue Dec 31, 2014 · 7 comments · Fixed by #51

Comments

@tpendragon
Copy link
Contributor

1.0.0.beta1 lets you hit a + and - button to add/remove values via javascript. The new form doesn't let you.

@jcoyne
Copy link
Member

jcoyne commented Dec 31, 2014

@terrellt Hmm, it's working for me on Sufia:
screen shot 2014-12-30 at 3 45 33 pm

Can you provide more info on how to duplicate the problem it?

@tpendragon
Copy link
Contributor Author

Maybe I'm missing some JS?

@jcoyne
Copy link
Member

jcoyne commented Dec 31, 2014

@tpendragon
Copy link
Contributor Author

Got it - jQuery UI dependency.

As an aside, how do you do the dropdowns?

@jcoyne
Copy link
Member

jcoyne commented Dec 31, 2014

@terrellt If there is some extra dependency can you document it? The dropdowns are actually in Sufia itself. We could move that into hydra-editor if there's interest. https://github.com/projecthydra/sufia/pull/819/files#diff-53b4e9e5a4ff6001b3ae6884198dded8R1

@tpendragon
Copy link
Contributor Author

Do you want me to add it as a gem dependency?

@jcoyne
Copy link
Member

jcoyne commented Dec 31, 2014

@terrellt Can you just document it for now. I didn't realize that widget was a part of jquery-ui. I'm tempted to rewrite to avoid that dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants