Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar Styling Changes #688

Closed
4 tasks done
joncameron opened this issue Oct 28, 2024 · 4 comments
Closed
4 tasks done

Progress bar Styling Changes #688

joncameron opened this issue Oct 28, 2024 · 4 comments
Assignees

Comments

@joncameron
Copy link
Contributor

joncameron commented Oct 28, 2024

Description

The current behavior of the progress bar often makes it difficult to interact with. Changes like removing the animation to provide a stable area of interaction in favor of increasing the initial height of the progress bar will make these events fire over a larger area.

Done Looks Like

  • Remove animation that changes height of the progress bar
  • Increase general height value of the progress bar (match full height on hover)
  • Broader area for progress bar for interaction events
  • Progress ball appears in front of transparent load progress bar

Examples

The target area for the mouseover is too small, making actions unavailable for users even in some cases where the mouse cursor is over progress bar:
Oct-30-2024 13-43-36

The playhead/ball icon is behind the colored strips representing load progress:
Screenshot 2024-10-30 at 1 48 05 PM

Mockup of the progress bar with a greater height value:
Screenshot 2024-10-30 at 1 47 01 PM

@joncameron
Copy link
Contributor Author

Increasing the height of the progress bar element should be easy; increasing the area of interaction might be more difficult.

@elynema
Copy link

elynema commented Nov 7, 2024

I have noticed one issue. When I scrub by clicking on the progress bar or dragging the playhead, the progress bar gets a sort of yellow glow around it. This remains until I pause and restart the audio/video or click elsewhere on the page. This doesn't happen when just playing / pausing / starting the playback or when using structure to navigate. Observed in Chrome and Safari on desktop. Also observed in Safari on iPhone and iPad with an audio item (but only on the second click in the progress bar) as well as on Android Chrome.

progress-bar-highlighted.mov

Desired behavior would be to remove that highlighting on the progress bard when the user scrubs (clicks in progress bar or drags the playhead).

@elynema
Copy link

elynema commented Nov 7, 2024

@joncameron Original styling requests in Done Looks Like look good to me across all platforms. You may want to take a quick look to see if you are happy as well.

Still need to QA the highlighting fix, which is currently on Ramp demo site only.

@joncameron
Copy link
Contributor Author

Yes, this looks good! I'm happier with this, and comparing between avalon-dev and the Ramp demo site makes it clear the progress bar looks better without the highlighting as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants